Merged
Conversation
apply early return to save horizontal space
apply early return to save horizontal space
move variable definitions closer to their use limit variable scope simplify branching by moving CT_TPAREN_OPEN check into SS_DANGLE if condition
limit variable scope
- limit range of possible input values by making the frm param a const reference - dereferences frm pointer in when calling insert_vbrace, adds nullptr guards for that - add early returns to save horizontal space - (personal preference) replace ugly do while loop
- limit range of possible input values by making the frm param a const reference - remove unused pc param - add early returns to save horizontal space
- move variable definitions closer to their use
- move variable definitions closer to their use - fix a typo - limit variable scope - directly return result from the close_statement function as that will lead to the same result in the end
- add newlines to enhance visibillity - eliminate needless nesting of successive if checks - apply const to variables
- add down-case 'pse_tos' to int in order to prevent up-casting of the '1' and enable possible signed-ness of the to be calculated value - eliminate needless nesting of successive if checks - add todo comment for the enum hack, replace cast - limit variable scope - add missing nullptr check - replace C style error string generation with std::cerr stream
- add early returns to save horizontal space
- move variable definitions closer to their use - replace memset with an aggregate-initialization - eliminate needless nesting of successive if checks
- add missing nullptr check, throw if frm is nullptr to guard a possible re-initialization of frm - add early returns to save horizontal space - replace memset with an brace (aggregate) initialization
- (subjective) simplifies function by moving loop flow statements into for loops headers
- use vector to store chunk_t* elements, minimizes upfront element initialization (testbase uses max 16 elements), allows to handle more elements than a fixed max number - move variable definitions closer to their use
- move variable definitions closer to their use - limit variable scope
- eliminate needless nesting of successive if checks
- fixes coverity 76006
- eliminate needless nesting of successive if checks - move variable definitions closer to their use
- move variable definitions closer to their use - limit variable scope - eliminate needless nesting of successive if checks
- move variable definitions closer to their use - limit variable scope - eliminate needless nesting of successive if checks
- move variable definitions closer to their use - limit variable scope - eliminate needless nesting of successive if checks - replace memset with brace (aggregate) initializer - combine if checks with identical bodys - move some single condition checks before multi condition checks in 'if' heads - remove useless parenthesis pairs
- add early returns to save horizontal space
- add early returns to save horizontal space
- move variable definitions closer to their use - eliminate needless nesting of successive if checks, simplify if checks
- add comments - reorder - add a safer abs calculation
- move variable definitions closer to their use - remove useless parenthesis pairs - limit variable scope - use a safer size_t abs calculation
Collaborator
Author
|
Could you make a Coverity run again? The numbers should drop. I googled a bit, we can use Travis for Cron jobs, maybe we could tweek the scripts made for the rsyslog project: https://github.com/rsyslog/rsyslog/commit/6c05f4126949fd25f36647a070ce590c9544b187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some of the refactoring commits I gathered over the time.