Merged
Conversation
after this commit every comment in the configs is one that is actually needed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of some PRs to clean up the current test configs.
The option_reducer.py script that will be used to remove unneeded options internally uses Uncrustify. Because of that all config options get re-aligned, re-sorted, every comment is removed and every include is resolved.
Some of the removed comments and options are important for the tests and need to be kept.
This PR removes default options and mostly focuses on removal of unneeded comments.
ref: #1128
The dirty scripts used to generate this PR are: here and here