Skip to content

Add options for empty function calls and rename nl_func_def method#1364

Merged
gmaurel merged 2 commits intouncrustify:masterfrom
brmqk3:nl_func_call_options
Oct 12, 2017
Merged

Add options for empty function calls and rename nl_func_def method#1364
gmaurel merged 2 commits intouncrustify:masterfrom
brmqk3:nl_func_call_options

Conversation

@brmqk3
Copy link
Copy Markdown
Contributor

@brmqk3 brmqk3 commented Sep 29, 2017

This pull request brings in two commits:

  1. Adds options for empty function calls
  2. Renames nl_func_def to nl_func_def_or_call since it now also deals with function calls.

This adds two options:
*nl_func_call_empty - same as nl_func_decl_empty but for
function calls
*nl_func_call_paren_empty - same as nl_func_def_paren_empty
but for function calls

Change-Id: Ib49ca03b18043368ceeb96e2c6f4fcfed3928ccb
@gmaurel
Copy link
Copy Markdown
Collaborator

gmaurel commented Sep 30, 2017

It is not clear if you mean "the option" or the "name of the function in the code".
Please change the description to:
_Rename the function name nl_func_def to show it deals with calls _

Renaming nl_func_def to nl_func_def_or_call because it now
deals with newlines in function calls.

Change-Id: Ifd601f7b483edb2b3443ce421298c17b0064596e
@brmqk3 brmqk3 force-pushed the nl_func_call_options branch from 4c9d032 to 5e22dcb Compare October 3, 2017 22:15
@gmaurel gmaurel merged commit 6a24c02 into uncrustify:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants