Merged
Conversation
CDanU
reviewed
May 9, 2017
tests/config/bug_1002.cfg
Outdated
| indent_columns = 4 | ||
| sp_arith = force | ||
| sp_assign = force | ||
| sp_bool = force |
Collaborator
There was a problem hiding this comment.
Are all of those needed?
As far as I understand the problem, only sp_before_byref/sp_after_byref and sp_bool should be involved.
The option sp_bool should be activated while both of the other options should not.
CDanU
reviewed
May 9, 2017
tests/input/cpp/bug_1002.cpp
Outdated
| @@ -0,0 +1,4 @@ | |||
| template< class B1 = void, class B2 = void > | |||
| struct conjunction : bool_constant<B1::value1 && B2::value2> | |||
Collaborator
There was a problem hiding this comment.
I just noticed this, you are not testing if sp_bool = force is actually doing anything here.
You could do this:
struct conjunction : bool_constant<B1::value1 && B2::value2>
struct conjunction : bool_constant<B1::value1&&B2::value2>There should also be a test with remove. The other two mentioned options (sp_before_byref, sp_after_byref ) should also be included to make sure that they are not causing misbehavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test if not in template