Skip to content

Upgrade to Gradle 8#132

Merged
tkrullmann merged 2 commits into
unbroken-dome:masterfrom
neeme-praks-sympower:upgrade-to-gradle-8
Aug 27, 2023
Merged

Upgrade to Gradle 8#132
tkrullmann merged 2 commits into
unbroken-dome:masterfrom
neeme-praks-sympower:upgrade-to-gradle-8

Conversation

@neeme-praks-sympower

@neeme-praks-sympower neeme-praks-sympower commented Feb 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Upgrade to Gradle 8 (Gradle wrapper)
  • Update com.gradle.plugin-publish plugin to 1.1.0 (previous version is not compatible with Gradle 8)
  • Update publishing section of the build file to make it work with the new publishing plugin (at least it does not fail anymore)
  • Fix Gradle plugin API compatibility issue in TestSetsPlugin.kt

Fixes #131

catostrophe
catostrophe reviewed Feb 14, 2023
View reviewed changes
Comment thread src/main/kotlin/org/unbrokendome/gradle/plugins/testsets/TestSetsPlugin.kt Outdated
@neeme-praks-sympower @catostrophe
Remove API deprecation suppression
591c8fe 
As we now use the new API

Co-authored-by: catostrophe <40268503+catostrophe@users.noreply.github.com>
@catostrophe

catostrophe commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

BTW. If a Gradle plugin is built with Gradle 8, what minimal Gradle version it will be working with?

@neeme-praks-sympower

neeme-praks-sympower commented Feb 14, 2023

Copy link
Copy Markdown
Contributor Author

BTW. If a Gradle plugin is built with Gradle 8, what minimal Gradle version it will be working with?

I'm not a specialist but as far as I understand, as long as the plugin does not use any newer API, it will continue to work with Gradle 5.1 as before.
BTW, in hindsight I now realise that upgrade to Gradle 8 is not actually necessary to fix this API compatibility. I can remove that part of the PR, if you like.

@catostrophe

catostrophe commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

I am not a maintainer and don't have an opinion regarding bumping the Gradle version. I just wanted to make sure that doing that won't make the plugin incompatible with Gradle 6+.

@catostrophe

catostrophe commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

@tkrullmann are you still maintaining this project?

@catostrophe

catostrophe commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

This project seems abandoned. I would recommend migrating to JVM Test Suite plugin

@tomasbjerre tomasbjerre mentioned this pull request Mar 1, 2023
Closed
@breedx-splk breedx-splk mentioned this pull request Mar 8, 2023
Merged
@piyushmor

piyushmor commented May 4, 2023 •
edited
Loading

Copy link
Copy Markdown

why is this still pending?

@rd-janina-nemec

rd-janina-nemec commented Jun 26, 2023

Copy link
Copy Markdown

Why is this not merged yet?

@tkrullmann tkrullmann merged commit e59b535 into unbroken-dome:master Aug 27, 2023
@lfarkas

lfarkas commented Aug 27, 2023

Copy link
Copy Markdown

a release also needed...in order to be able to use it...

@pavelchuchma

pavelchuchma commented Sep 5, 2023

Copy link
Copy Markdown

@tkrullmann any estimate of release with this fix, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@catostrophe catostrophe catostrophe left review comments

@lfarkas lfarkas lfarkas approved these changes

@mderouet mderouet mderouet approved these changes

@medgate-admin medgate-admin medgate-admin approved these changes

@giovanni-nabil giovanni-nabil giovanni-nabil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plugin application fails on Gradle 8.0

10 participants

@neeme-praks-sympower @catostrophe @piyushmor @rd-janina-nemec @lfarkas @pavelchuchma @mderouet @medgate-admin @giovanni-nabil @tkrullmann