Conversation
🦋 Changeset detectedLatest commit: 84fc4ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate limit exceeded@JounQin has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 9 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to b0a81a6 in 57 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/core/src/helpers.ts:93
- Draft comment:
Merge options correctly: The new 'else if' branch now spreads entryOrOptions and options. Consider using a fallback (e.g. ...(options ?? {})) to ensure options is always an object. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_MkKt8SvBHSJOt8tm
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
@pkgr/browser
@pkgr/core
@pkgr/es-modules
@pkgr/imagemin
@pkgr/rollup
@pkgr/umd-globals
@pkgr/utils
commit: |
|
Deploy preview for pkgr ready! ✅ Preview Built with commit 84fc4ab. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logic in findUp so that when callers pass an options object as the first argument, it’s merged correctly into the existing options.
- Adds an
else ifbranch to mergeentryOrOptionsintooptionswhen it’s provided as an object. - Ensures both entry and search parameters can be overridden via the first-argument options.
Comments suppressed due to low confidence (2)
packages/core/src/helpers.ts:94
- Add or update unit tests to cover this new merge branch (when
entryOrOptionsis an options object) to ensure expected behavior and catch regressions.
options = { ...entryOrOptions, ...options }
packages/core/src/helpers.ts:93
- Make the branch condition more explicit by checking for an object type (e.g.,
typeof entryOrOptions === 'object') instead of relying on truthiness, to avoid unintentionally handling non-object values.
} else if (entryOrOptions) {
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
=========================================
- Coverage 9.72% 9.67% -0.05%
=========================================
Files 12 12
Lines 432 434 +2
Branches 185 187 +2
=========================================
Hits 42 42
- Misses 390 392 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed c329fe3 in 1 minute and 38 seconds. Click for details.
- Reviewed
24lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/core/src/helpers.ts:93
- Draft comment:
Avoid reassigning the parameter 'options'; consider using a new variable for clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. .changeset/tasty-mayflies-build.md:5
- Draft comment:
Typo: 'hadnle' should be corrected to 'handle'. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_y1VNgMyzu2vDysf2
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
options correctlyoptions correctly
Important
Fixes handling of
optionsinfindUpfunction to correctly mergeentryOrOptionswithoptions.optionsinfindUpfunction inhelpers.tsto correctly mergeentryOrOptionswithoptionswhenentryOrOptionsis not a string.tasty-mayflies-build.mdfor patch update of@pkgr/core.This description was created by
for c329fe3. You can customize this summary. It will automatically update as commits are pushed.