Update SSL autocert to dynamically check discovered servers#234
Merged
Update SSL autocert to dynamically check discovered servers#234
Conversation
The DecisionFunc in makeAutocertManager now checks both static FQDNs and dynamic servers from discovery providers. This allows new services (docker containers, file config changes, consul updates) to get SSL certificates without requiring reproxy restart. Also fixes a race condition in discovery logging by using %T instead of %s when formatting providers to prevent reflection on context fields. Related to #207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
app/proxy/ssl.go:
CheckDomainmethod toAutocertManagerinterface for testingDecisionFuncto check both static FQDNs (for explicit config) AND dynamich.Servers()(for discovery providers)app/proxy/ssl_test.go:
TestSSL_DynamicFQDNsverifying domains added dynamically viaServers()are acceptedapp/discovery/discovery.go:
%sto%Tin provider logging to prevent race condition when context is cancelled during formattingRelated to #207