Skip to content

Skip SSL check for the destination host#170

Merged
umputun merged 3 commits intoumputun:masterfrom
themagic314:ignore-ssl-cert-check
Jan 7, 2024
Merged

Skip SSL check for the destination host#170
umputun merged 3 commits intoumputun:masterfrom
themagic314:ignore-ssl-cert-check

Conversation

@themagic314
Copy link
Contributor

Related to #162

Is it okay to use the option name "insecure"? Or should we use somtehing more explicit?

@themagic314 themagic314 requested a review from umputun as a code owner January 6, 2024 11:33
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to the nolint, it would be nice to have README updated: section about SSL and the overall list of CLI params

@themagic314
Copy link
Contributor Author

Params in overall list was already added, also added some explanation in "More options".

Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@umputun umputun merged commit 7d4394f into umputun:master Jan 7, 2024
@themagic314 themagic314 deleted the ignore-ssl-cert-check branch January 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants