Skip to content

fix: Modify the example to avoid misunderstanding#1960

Merged
umputun merged 1 commit intoumputun:masterfrom
km0e:update_doc
Dec 4, 2025
Merged

fix: Modify the example to avoid misunderstanding#1960
umputun merged 1 commit intoumputun:masterfrom
km0e:update_doc

Conversation

@km0e
Copy link
Copy Markdown
Contributor

@km0e km0e commented Oct 14, 2025

In the section On a separate domain, it may be misleading to see that ALLOWED_HOSTS is set to some domain names. Although the domain names here refer to URLs, it is recommended to modify them slightly.

@km0e km0e requested a review from umputun as a code owner October 14, 2025 13:43
@paskal
Copy link
Copy Markdown
Collaborator

paskal commented Oct 14, 2025

Will check against the spec and get back with review.

@paskal
Copy link
Copy Markdown
Collaborator

paskal commented Dec 4, 2025

@paskal
Copy link
Copy Markdown
Collaborator

paskal commented Dec 4, 2025

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Additional verification: The change to add https:// protocol prefix to domains in the ALLOWED_HOSTS example is correct according to:

  • CSP frame-ancestors specification which allows scheme + hostname format
  • The existing test in backend/app/rest/api/rest_test.go which uses https://example.com format

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@umputun umputun merged commit 3013d03 into umputun:master Dec 4, 2025
1 check passed
@paskal paskal added this to the v1.15.0 milestone Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants