Skip to content

Fix CSP img-src directive to allow everything without proxy#1825

Merged
umputun merged 1 commit intomasterfrom
paskal/fix_img_src_CSP
Oct 20, 2024
Merged

Fix CSP img-src directive to allow everything without proxy#1825
umputun merged 1 commit intomasterfrom
paskal/fix_img_src_CSP

Conversation

@paskal
Copy link
Copy Markdown
Collaborator

@paskal paskal commented Oct 20, 2024

Change the default img-src value to "*" and sets it to "'self'" when image proxy is enabled. The previous state was inversion of this logic which was wrong.

@github-actions
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 11429498254

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.898%

Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/app/rest/api/rest.go 1 2 50.0%
Totals Coverage Status
Change from base Build 11355610412: 0.0%
Covered Lines: 5987
Relevant Lines: 7052

💛 - Coveralls

Change the default img-src value to "*" and sets it to "'self'" when
image proxy is enabled. The previous state was inversion of this logic
which was wrong.
@paskal paskal force-pushed the paskal/fix_img_src_CSP branch from 8c0784b to f3e8fe3 Compare October 20, 2024 20:52
@paskal paskal marked this pull request as ready for review October 20, 2024 20:53
@paskal paskal requested a review from umputun as a code owner October 20, 2024 20:53
@umputun umputun merged commit 6140d82 into master Oct 20, 2024
@umputun umputun deleted the paskal/fix_img_src_CSP branch October 20, 2024 20:55
@paskal paskal added this to the v1.14.0 milestone Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants