fix: Apple login integration#1806
Merged
umputun merged 5 commits intoumputun:masterfrom Aug 24, 2024
tomy0000000:master
Merged
Conversation
Contributor
Author
|
resolves #1789 |
paskal
previously approved these changes
Aug 12, 2024
Collaborator
There was a problem hiding this comment.
LGTM!
Could you please also update server.go CLI param comment to match your changes in the parameters/index.md, and prepare a PR which would update the https://github.com/go-pkgz/auth?tab=readme-ov-file#apple-auth-provider documentation as well?
Also a nitpick, please keep the list numeration to 1. everywhere: that way you never need to update it in case elements are changing order or removed from the middle.
And also you need to write resolves 1789 to the original message for this PR to resolve that issue.
Contributor
Author
|
Done! See also go-pkgz/auth#212 |
Contributor
Author
paskal
approved these changes
Aug 23, 2024
umputun
approved these changes
Aug 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #1789, Apple login was broken in #1617.
I removed the problematic lines, recompiled a docker image, and confirmed the bug was indeed caused by the wrong
ResponseModeparams.In addition, I've also improved some sections of docs about how to configure credentials used by Apple integration. One thing worth mentioning is that the term "Client ID" used by remark42 does not appear in Apple's developer dashboard but is used in some documentation, which can cause some confusion. Therefore, I added an annotation indicating that the "Client ID" can be either "App ID" or "Service ID".
resolves #1789