add pagination to GET /api/v1/find endpoint#1699
Merged
Conversation
Pull Request Test Coverage Report for Build 7512258238
💛 - Coveralls |
33b4f77 to
09ee26d
Compare
f7f18c8 to
d099924
Compare
d099924 to
4bbb980
Compare
4bbb980 to
162a2da
Compare
umputun
requested changes
Dec 9, 2024
Owner
umputun
left a comment
There was a problem hiding this comment.
few minor things. I have not checked the tree part of this, and asked for some tests to make sure everyting is working as designed.
| if offsetID != "" { | ||
| for i, comment := range c { | ||
| if comment.ID == offsetID { | ||
| c = c[i+1:] |
Owner
There was a problem hiding this comment.
This is confusing and even scary a bit. Generally, the idea of changing the slice we are ranging over inside the loop feels wrong to me. Probably it is safe to do now, as we are breaking right away, but someday, as we add code to this function, it may not be the case. I'd rather add a new lcs variable for the result slice.
`format=tree` pagination provides top-level comments with all replies and returns the last top-level comment as `last_comment` to be used as `offset` for the next page. If comments and replies overflow the limit, the one stepping out of the limit will not be returned. If the first comment and its replies after the given offset overflow the limit, it will be returned with all the replies. `format=plain` pagination works by providing all comments and returning the last comment as `last_comment` to be used as `offset` for the next page.
162a2da to
82a0888
Compare
Pull Request Test Coverage Report for Build 12265398108Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format=treepagination provides top-level comments with all replies and returns the last top-level comment aslast_commentto be used asoffsetfor the next page. If comments and replies overflow the limit, the one stepping out of the limit will not be returned. If the first comment and its replies after the given offset overflow the limit, it will be returned with all the replies.format=plainpagination works by providing all comments and returning the last comment aslast_commentto be used asoffsetfor the next page.Requires #1685 to be merged first. Backend part for #782.