Merged
Conversation
when navigating through an anchor
make it use tailwind styles
akellbl4
reviewed
Jun 6, 2023
site/src/styles.css
Outdated
Comment on lines
+201
to
+205
| @apply content-['']; | ||
| @apply block; | ||
| @apply h-16; | ||
| @apply -mt-16; | ||
| @apply invisible; |
Collaborator
There was a problem hiding this comment.
Suggested change
| @apply content-['']; | |
| @apply block; | |
| @apply h-16; | |
| @apply -mt-16; | |
| @apply invisible; | |
| @apply content-[''] block h-16 -mt-16 invisible; |
Collaborator
There was a problem hiding this comment.
@Jaskon did you check the change on mobile? Height of the header on mobile is different from desktop.
Contributor
Author
There was a problem hiding this comment.
You are right. Have fixed it for mobiles.
use different header size on mobiles and desktops
akellbl4
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anchor offset when navigating through an anchor.
It's now scrolling a bit further, to make a section-header also visible on the screen.
(Previously, selected section-header was hidden under the global page-header)
Unfortunately, I don't know how to get rid of the outline, when navigation through an anchor, as it's applied to the parent of styled element. The only way I see here - modify markdown-it-anchor sources (or use some different approach here)