update iframe size on textarea size change#1541
Merged
Conversation
size-limit report 📦
|
Codecov ReportBase: 57.95% // Head: 58.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1541 +/- ##
==========================================
+ Coverage 57.95% 58.04% +0.09%
==========================================
Files 131 131
Lines 2916 2920 +4
Branches 745 746 +1
==========================================
+ Hits 1690 1695 +5
+ Misses 1094 1093 -1
Partials 132 132
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Mavrin
approved these changes
Dec 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing this comment
MutationObserverdoesn't spot some changes on textarea value changes (expecially on paste) so we add additional resize event on textarea size updates.cc @damienalexandre