fix iframe resize on auth dropdown opening#1490
Merged
Conversation
Codecov ReportBase: 58.12% // Head: 58.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
- Coverage 58.12% 58.07% -0.06%
==========================================
Files 131 131
Lines 2909 2910 +1
Branches 743 743
==========================================
- Hits 1691 1690 -1
- Misses 1214 1216 +2
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
size-limit report 📦
|
Collaborator
|
I installed it on https://terrty.net/2022/self-hosted-comments-remark42/ Safari, Chrome first load in Incognito: |
Collaborator
Author
|
@paskal thank you for testing the fix. I see in prod env it behave slightly different. |
Mavrin
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutation observer was listening for all of the elements. When Auth dropdown appears it renders images and triggering height recalculations.
Resize trigger on image load was introduced in favor of resizing iframe for users with slow internet (when images load later and we need to resize iframe accordingly)
Solution:
Listen to mutations only on block with comments.
Plus remove unnecessary triggers.