Skip to content

Use simple size-limit adapter#1408

Merged
akellbl4 merged 2 commits intomasterfrom
use-simple-size-adapter
Jul 12, 2022
Merged

Use simple size-limit adapter#1408
akellbl4 merged 2 commits intomasterfrom
use-simple-size-adapter

Conversation

@akellbl4
Copy link
Copy Markdown
Collaborator

@akellbl4 akellbl4 commented Jul 10, 2022 •
edited
Loading

can be merged only after #1404

Move back to @size-limit/file because @size-limit/app is not that useful and creates more noise than helps with understanding if bundle size is increased.

@akellbl4 akellbl4 requested a review from Mavrin July 10, 2022 22:04
@akellbl4 akellbl4 requested a review from umputun as a code owner July 10, 2022 22:04
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2022 •
edited
Loading

Codecov Report

Merging #1408 (571df25) into master (2e777ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1408   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         131      131           
  Lines        2909     2909           
  Branches      699      699           
=======================================
  Hits         1691     1691           
  Misses       1214     1214           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e777ea...571df25. Read the comment docs.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 10, 2022 •
edited
Loading

size-limit report 📦

Path Size
public/embed.mjs 2.02 KB (0%)
public/remark.mjs 72.21 KB (-0.01% 🔽)
public/remark.css 8.2 KB (0%)
public/last-comments.mjs 35.5 KB (0%)
public/last-comments.css 3.79 KB (-0.03% 🔽)
public/deleteme.mjs 12.04 KB (0%)
public/counter.mjs 749 B (0%)

Mavrin
Mavrin previously approved these changes Jul 11, 2022
View reviewed changes
umputun
umputun previously approved these changes Jul 11, 2022
View reviewed changes
@akellbl4 akellbl4 force-pushed the switch-to-pnpm branch 3 times, most recently from 09be685 to 1cab9b0 Compare July 11, 2022 23:42
@akellbl4 akellbl4 force-pushed the use-simple-size-adapter branch from b44b4d1 to a558b5e Compare July 12, 2022 00:19
Base automatically changed from switch-to-pnpm to master July 12, 2022 03:13
@akellbl4 akellbl4 dismissed stale reviews from umputun and Mavrin via a558b5e July 12, 2022 03:13
Mavrin
Mavrin previously approved these changes Jul 12, 2022
View reviewed changes
@Mavrin Mavrin self-requested a review July 12, 2022 11:31
@umputun
Copy link
Copy Markdown
Owner

umputun commented Jul 12, 2022

conflicts

umputun
umputun previously approved these changes Jul 12, 2022
View reviewed changes
@akellbl4 akellbl4 dismissed stale reviews from umputun and Mavrin via 71cddaa July 12, 2022 17:16
@akellbl4 akellbl4 force-pushed the use-simple-size-adapter branch from a558b5e to 71cddaa Compare July 12, 2022 17:16
@akellbl4 akellbl4 force-pushed the use-simple-size-adapter branch from 71cddaa to 571df25 Compare July 12, 2022 17:22
@akellbl4
Copy link
Copy Markdown
Collaborator Author

akellbl4 commented Jul 12, 2022

@umputun can be merged

@akellbl4 akellbl4 changed the title Use simple size adapter Use simple size-limit adapter Jul 12, 2022
@akellbl4 akellbl4 merged commit 3c90f6a into master Jul 12, 2022
@akellbl4 akellbl4 deleted the use-simple-size-adapter branch July 12, 2022 20:34
@paskal paskal added this to the v1.10.2 milestone Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umputun umputun umputun approved these changes

@Mavrin Mavrin Mavrin approved these changes

Assignees

No one assigned

Labels

frontend

Projects

None yet

Milestone

v1.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@akellbl4 @umputun @Mavrin @paskal