Conversation
Codecov Report
@@ Coverage Diff @@
## master #1396 +/- ##
=======================================
Coverage 51.90% 51.90%
=======================================
Files 138 138
Lines 2998 2998
Branches 695 695
=======================================
Hits 1556 1556
Misses 1434 1434
Partials 8 8 Continue to review full report at Codecov.
|
Merged
Mavrin
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The size job failed because this problem. It simply updates packages that couldn't be resolved and packages around in order to have fresh packages for whole eslint ecosystem on the project.
Also removes jest plugin for eslint because it is already included in preact preset https://github.com/preactjs/eslint-config-preact/blob/master/index.js#L27
npm errors
FIY Size job will be failing until we have these changes in master because it's running
npm installfor master as well.