fix: also pass TZ env var in docker wrapper for Go timezone#297
Merged
fix: also pass TZ env var in docker wrapper for Go timezone#297
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Docker wrapper so containerized runs use the host timezone consistently for both the base image’s OS timezone configuration and Go’s runtime timezone handling (fixing progress-log timestamps rendering as UTC in-container).
Changes:
- Set both
TIME_ZONEandTZinbuild_base_env_vars()from a singledetect_timezone()result. - Update the wrapper’s unit test to assert both env vars are present and match.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/ralphex-dk.sh | Forward detected host timezone as both TIME_ZONE (baseimage) and TZ (Go) to keep timestamps consistent. |
| scripts/ralphex-dk/ralphex_dk_test.py | Extend tests to validate both TIME_ZONE and TZ are included and correctly set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #153. That fix detected the host timezone and forwarded it to the container as
TIME_ZONE, but Go'stime.Now()reads the standardTZenv var, notTIME_ZONE, so progress-log timestamps still rendered UTC inside the container.build_base_env_vars()now sets both:TIME_ZONE(consumed by baseimage to configure/etc/localtime) andTZ(consumed by Go'stime.Local). Both come from the samedetect_timezone()result so they can't drift.Closes #295