fix: do not assign Field method to Rule#3181
Merged
Merged
Conversation
931df27 to
5540800
Compare
Doing so, `parse` wall called with the wrong `this`, which ended up in an infinite loop, as it was then calling `this.cast` on the Rule itself, which has been set to `parse`… fix #3179
5540800 to
c297a3c
Compare
davidbgk
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing so,
parsewall called with the wrongthis, which ended up in an infinite loop, as it was then callingthis.caston the Rule itself, which has been set toparse…fix #3179