perfs: do not add features and filters in data browser DOM until user use them#3165
Merged
Conversation
When opening the data browser (left panel), the DOM is huge, so let's clean it, not to clutter memory Co-authored-by: David Larlet <david@larlet.fr>
Filters can be huge, so let's not polute the DOM pointlessly Co-authored-by: David Larlet <david@larlet.fr>
When there are a lot of features and/or a lot of datalayers, this can make the DOM huge. The DOM will also be computed when some filter is active (so we can compute the current/total count). Co-authored-by: David Larlet <david@larlet.fr>
Co-authored-by: David Larlet <david@larlet.fr>
Co-authored-by: David Larlet <david@larlet.fr>
We have two form classes: - Form, used for imports, filters… - MutatingForm, used for data manipulation Only this later is synced (to other peers), so no need to have a debounce for the former. We could even make this debounce more smart in a later step, by only activating it when the map is actually in sync mode, otherwise we do not need it either (and it slows down tests…). Co-authored-by: David Larlet <david@larlet.fr>
Co-authored-by: David Larlet <david@larlet.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.