chore: use ESM version of Leaflet.LocateControl#3137
Merged
Conversation
For now, we do not use an importmap (breaks our baseline), so we hardcoded the path to leaflet module in the plugin… Let's make this cleaner later, when our baseline is ready for importmaps, or we are ready to break more old browsers (hello palemoon… :) ) Co-authored-by: David Larlet <david@larlet.fr>
2925c74 to
1d44ce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, we do not use an importmap (breaks our baseline), so we hardcoded the path to leaflet module in the plugin…
Let's make this cleaner later, when our baseline is ready for importmaps, or we are ready to break more old browsers (hello palemoon… :) )