NOISSUE - Implement structured logging with log forwarding for ingress-proxy and computation-runner, update component versions, and improve aTLS initialization and error handling.#583
Merged
Conversation
…roxy` and `computation-runner`, update component versions, and improve aTLS initialization and error handling. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…component versions. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…nternal CVM server TLS to Ingress Proxy, and update component versions. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
ingress-proxy and computation-runner, update component versions, and improve aTLS initialization and error handling.ingress-proxy and computation-runner, update component versions, and improve aTLS initialization and error handling.
…h and remove local development keys and encrypted algorithm. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
==========================================
+ Coverage 73.49% 73.54% +0.04%
==========================================
Files 99 96 -3
Lines 6358 6123 -235
==========================================
- Hits 4673 4503 -170
+ Misses 1265 1205 -60
+ Partials 420 415 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| teeNonce := append(pubKey, nonce...) | ||
| hashNonce := sha3.Sum512(teeNonce) | ||
| // The attestation provider truncates the 64-byte hash to 32 bytes before sending it to the TEE | ||
| expectedNonce := hashNonce[:32] |
Contributor
There was a problem hiding this comment.
Why is the hash nonce 32 bytes? Is there a specific reason.
Contributor
Author
There was a problem hiding this comment.
The reason we truncate the 64-byte sha3.Sum512 hash to 32 bytes is to satisfy the AttestationService gRPC API and the EAT token claims standard (RFC 9711).
API Consistency: The AttestationService interface specifically defines the Nonce field as 32 bytes (256 bits).
I will add a comment as well
…erver implementations. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes