Skip to content

COCOS-525-487 - Refactor attestation and atls#562

Merged
dborovcanin merged 3 commits into
ultravioletrs:mainfrom
SammyOina:cocos-525-487
Feb 18, 2026
Merged

COCOS-525-487 - Refactor attestation and atls#562
dborovcanin merged 3 commits into
ultravioletrs:mainfrom
SammyOina:cocos-525-487

Conversation

@SammyOina

@SammyOina SammyOina commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

What does this do?

  • Refactor

    • Consolidated attestation handling and TLS configuration management under improved internal organization for better maintainability and code clarity.
  • Chores

    • Updated dependency management in build configuration.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

to be merged after #561

@codecov

codecov Bot commented Jan 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.88235% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.85%. Comparing base (de50b6d) to head (106badb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/attestation/vtpm/sev.go 57.89% 8 Missing ⚠️
pkg/attestation/vtpm/vtpm.go 25.00% 3 Missing ⚠️
pkg/attestation/azure/snp.go 66.66% 1 Missing ⚠️
pkg/clients/http/client.go 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   70.84%   70.85%   +0.01%     
==========================================
  Files          91       91              
  Lines        6390     6400      +10     
==========================================
+ Hits         4527     4535       +8     
+ Misses       1459     1457       -2     
- Partials      404      408       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Removed references to quoteprovider in various files, replacing them with vtpm where necessary.
- Updated function signatures and implementations to use SEVNonce instead of quoteprovider.Nonce.
- Introduced new vtpm package to handle SEV-related attestation logic, including fetching and verifying attestation reports.
- Adjusted tests to reflect changes in the attestation logic and ensure compatibility with the new structure.
- Deleted the now redundant quoteprovider/sev_test.go file.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…efactor client code to utilize new TLS utilities

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@dborovcanin dborovcanin merged commit 207bfd9 into ultravioletrs:main Feb 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate Client from TLS Feature: Refactor attestation package

3 participants