NOISSUE - Introduce a dedicated attestation service and refactor agent to use its gRPC client#558
Merged
Conversation
… use its gRPC client Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…installation process. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…ent attestation logic. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…sure Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
==========================================
- Coverage 69.34% 68.84% -0.51%
==========================================
Files 76 77 +1
Lines 5568 5594 +26
==========================================
- Hits 3861 3851 -10
- Misses 1364 1400 +36
Partials 343 343 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dborovcanin
requested changes
Dec 17, 2025
… and update corresponding service implementation. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Architecture Changes and Future Splits
Current Architecture Changes
The
cocos-agenthas been refactored to separate the hardware attestation logic into a dedicated component:attestation-service.Attestation Service: A standalone service running as
attestation-servicesystemd unit./run/cocos/attestation.sock).Agent (Coordinator): The main
cocos-agentprocess./dev/tpmor/dev/sev. Instead, it connects to theattestation-servicevia gRPC to request attestation reports.Future Component Splits
To further enhance security and modularity, the following components are proposed to be split from the monolithic agent:
1. Egress Scrutinizer / Networking Proxy
2. Computation Runner / Workload Executor
seccomp,namespaces, or nested VMs/containers) and returns only the result. This protects the agent (coordinator) from crashes or exploits in user code.3. Log/Event Forwarder
Diagram (Simplied)
graph TD Hardware[Hardware TPM/TDX/SNP] AttSock[Attestation Socket /run/cocos/attestation.sock] subgraph PrivilegedLayer["Privileged Layer"] AttSvc[Attestation Service] end subgraph WorkloadLayer["Workload Layer"] Agent[Agent Coordinator] end AttSvc -->|Controls| Hardware AttSvc -->|Listens| AttSock Agent -->|Connects| AttSockWhich issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes