Skip to content

NOISSUE - Refactor result command to improve output path handling and update usage instructions#549

Merged
dborovcanin merged 3 commits into
ultravioletrs:mainfrom
SammyOina:prism-1073
Nov 10, 2025
Merged

NOISSUE - Refactor result command to improve output path handling and update usage instructions#549
dborovcanin merged 3 commits into
ultravioletrs:mainfrom
SammyOina:prism-1073

Conversation

@SammyOina

Copy link
Copy Markdown
Contributor

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

…age instructions

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina requested a review from Copilot November 10, 2025 14:18
…creation and remove redundant comments

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the result command to improve usability by replacing the positional filename argument with explicit flags. The command now supports specifying both the output directory and filename through CLI flags, with improved user feedback showing the absolute path of the saved file.

  • Replaced positional filename argument with --filename and --output-dir flags
  • Added automatic directory creation when --output-dir is specified
  • Enhanced output to display the absolute path of the saved result file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cli/result.go Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov

codecov Bot commented Nov 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.28%. Comparing base (de8e198) to head (6d9be30).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/result.go 69.56% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   69.30%   69.28%   -0.02%     
==========================================
  Files          76       76              
  Lines        5554     5568      +14     
==========================================
+ Hits         3849     3858       +9     
- Misses       1363     1367       +4     
- Partials      342      343       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dborovcanin dborovcanin merged commit 291755e into ultravioletrs:main Nov 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants