NOISSSUE - Fix SEV-SNP attestation policy validation#541
Merged
Conversation
- Replace abi.ReportCertsToProto() with direct proto.Unmarshal() to bypass strict guest policy bit 17 validation that was failing - Change protojson.Marshal() to proto.Marshal() for binary protobuf output Signed-off-by: wkk <wkk@example.com>
- Remove fmt.Println debug statements from cmd/agent/main.go - Remove fmt.Println debug statements from pkg/atls/certificate_provider.go - Remove fmt.Println debug statements from pkg/attestation/azure/snp.go Signed-off-by: wkk <wkk@example.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
| return fmt.Errorf("failed to fetch TEE attestation report: %v", err) | ||
| } | ||
|
|
||
| extReport, err := abi.ReportCertsToProto(rawTeeAttestation) |
Contributor
There was a problem hiding this comment.
Why was this making a problem?
Contributor
Author
There was a problem hiding this comment.
{"agentLog":{"message":"Method Attestation took 58.752777ms to complete with error: failed to get vTPM quote : failed to convert TEE report to proto : malformed guest policy: mbz range policy[0x15:0x3f] not all zero: 73726576227b3a22", "level":"WARN", "timestamp":"2025-10-14T13:45:47.936604724Z"}}
{"agentLog":{"message":"failed to get attestation: failed to get vTPM quote : failed to convert TEE report to proto : malformed guest policy: mbz range policy[0x15:0x3f] not all zero: 73726576227b3a22", "level":"ERROR", "timestamp":"2025-10-14T13:45:47.936748503Z"}}
It brings this error
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
=======================================
Coverage 66.90% 66.90%
=======================================
Files 76 76
Lines 6884 6884
=======================================
Hits 4606 4606
Misses 1936 1936
Partials 342 342 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM |
SammyOina
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes