Skip to content

COCOS 492 - Fixes bug from 492, fetch certificates only for SEV-SNP cvms#536

Merged
drasko merged 6 commits into
ultravioletrs:mainfrom
jovan-djukic:issue-492
Oct 16, 2025
Merged

COCOS 492 - Fixes bug from 492, fetch certificates only for SEV-SNP cvms#536
drasko merged 6 commits into
ultravioletrs:mainfrom
jovan-djukic:issue-492

Conversation

@jovan-djukic

Copy link
Copy Markdown
Contributor

What type of PR is this?

This a bug fix.

What does this do?

Added a platform check before fetching the certificates.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@jovan-djukic jovan-djukic changed the title Issue 492 - bug fix COCOS 492 - bug fix Oct 13, 2025
@codecov

codecov Bot commented Oct 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.90%. Comparing base (04b0cdf) to head (623f107).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files          76       76           
  Lines        6884     6884           
=======================================
  Hits         4606     4606           
  Misses       1936     1936           
  Partials      342      342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SammyOina SammyOina changed the title COCOS 492 - bug fix COCOS 492 - Fixes bug from 492, fetch certificates only for SEV-SNP cvms Oct 13, 2025

@WashingtonKK WashingtonKK left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# cat /var/log/cocos/agent.stdout
WARN : 2025/10/14 13:45:54.457889 abi.go:917: Warning: Neither VCEK nor VLEK certificate found in data pages
WARN : 2025/10/14 13:45:47.936195 abi.go:917: Warning: Neither VCEK nor VLEK certificate found in data pages
{"agentLog":{"message":"Method Attestation took 58.752777ms to complete with error: failed to get vTPM quote : failed to convert TEE report to proto : malformed guest policy: mbz range policy[0x15:0x3f] not all zero: 73726576227b3a22", "level":"WARN", "timestamp":"2025-10-14T13:45:47.936604724Z"}}
{"agentLog":{"message":"failed to get attestation: failed to get vTPM quote : failed to convert TEE report to proto : malformed guest policy: mbz range policy[0x15:0x3f] not all zero: 73726576227b3a22", "level":"ERROR", "timestamp":"2025-10-14T13:45:47.936748503Z"}}

@jovan-djukic please have a look at this.

@drasko drasko merged commit cf32a25 into ultravioletrs:main Oct 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Cache VCEK on aTLS verification

4 participants