NOISSUE - Remove go-tpm-tools TEE verification#406
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 56.67% 56.87% +0.20%
==========================================
Files 59 59
Lines 5078 5051 -27
==========================================
- Hits 2878 2873 -5
+ Misses 1900 1876 -24
- Partials 300 302 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SammyOina
approved these changes
Mar 16, 2025
dborovcanin
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor because it changes the CLI attestation verification option. The
go-tpm-toolslibrary has depricated the TEE verification feature. This PR changes that and uses thego-sev-guestverification functions.What does this do?
This PR changes that and uses the
go-sev-guestverification functions instead of thego-tpm-toolsTEE verification in the CLI attestationvalidatecommand.Which issue(s) does this PR fix/relate to?
No issue.
Have you included tests for your changes?
Tests have been updated.
Did you document any new/modified feature?
No need for documentation.
Notes