NOISSUE - Add path to expected PCR values#398
Merged
Conversation
SammyOina
requested changes
Mar 10, 2025
| @@ -25,7 +25,12 @@ import ( | |||
| const defGuestFeatures = 0x1 | |||
|
|
|||
| func (ms *managerService) FetchAttestationPolicy(_ context.Context, computationId string) ([]byte, error) { | |||
Contributor
There was a problem hiding this comment.
can we write the output of the attestation policy bin to std out rather than json. that way manager can read and parse the command output and not worry about location of the output json fille
Contributor
Author
There was a problem hiding this comment.
Ok, I will change this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 56.67% 56.71% +0.04%
==========================================
Files 59 59
Lines 5078 5099 +21
==========================================
+ Hits 2878 2892 +14
- Misses 1900 1906 +6
- Partials 300 301 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SammyOina
requested changes
Mar 13, 2025
| return fmt.Errorf("error: %s", outputString) | ||
| } | ||
|
|
||
| fmt.Println(outputString) |
| @@ -12,6 +12,7 @@ The service is configured using the environment variables from the following tab | |||
| | COCOS_JAEGER_TRACE_RATIO | The ratio of traces to sample. | 1.0 | | |||
| | MANAGER_INSTANCE_ID | The instance ID for the manager service. | | | |||
| | MANAGER_ATTESTATION_POLICY_BINARY | The file path for the attestation policy and igvmmeassure binaries. | ../../build | | |||
Contributor
There was a problem hiding this comment.
we can have an env var for each
| stdout := bufio.NewWriter(&stdoutBuffer) | ||
| stderr := bufio.NewWriter(&stderrBuffer) | ||
|
|
||
| attestPolicyCmd, err := cmdconfig.NewCmdConfig("sudo", options, stderr, stdout) |
Contributor
There was a problem hiding this comment.
run returns output of stdout so no need to pass the buffer in the newmethod
SammyOina
requested changes
Mar 13, 2025
SammyOina
requested changes
Mar 14, 2025
Comment on lines
+45
to
+46
| AttestationPolicyBinary string `env:"MANAGER_ATTESTATION_POLICY_BINARY" envDefault:"../../build"` | ||
| IgvmMeasureBinary string `env:"MANAGER_IGVMMEASURE_BINARY" envDefault:"../../build"` |
Contributor
There was a problem hiding this comment.
Suggested change
| AttestationPolicyBinary string `env:"MANAGER_ATTESTATION_POLICY_BINARY" envDefault:"../../build"` | |
| IgvmMeasureBinary string `env:"MANAGER_IGVMMEASURE_BINARY" envDefault:"../../build"` | |
| AttestationPolicyBinary string `env:"MANAGER_ATTESTATION_POLICY_BINARY" envDefault:"../../build/attestation_policy"` | |
| IgvmMeasureBinary string `env:"MANAGER_IGVMMEASURE_BINARY" envDefault:"../../build/igvmmeasure"` |
SammyOina
approved these changes
Mar 14, 2025
dborovcanin
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature, because this PR introduces an env variable to the Manager that points to the PCR expected values JSON file.
What does this do?
This PR introduces an env variable to the Manager that points to the PCR expected values JSON file.
Which issue(s) does this PR fix/relate to?
No issue.
Have you included tests for your changes?
Tests have been updated.
Did you document any new/modified feature?
Yes.
Notes