Skip to content

COCOS-364 - Make agent more resilient to gRPC disconnection on cvms cloud server#375

Merged
drasko merged 10 commits into
ultravioletrs:mainfrom
SammyOina:cocos-364
Feb 16, 2025
Merged

COCOS-364 - Make agent more resilient to gRPC disconnection on cvms cloud server#375
drasko merged 10 commits into
ultravioletrs:mainfrom
SammyOina:cocos-364

Conversation

@SammyOina

@SammyOina SammyOina commented Feb 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

What does this do?

  • New Features
    • Enhanced state tracking with improved logging, metrics, and state exchange.
    • Added robust reconnection and pending message handling for improved client reliability.
  • Refactor
    • Streamlined server startup to run asynchronously.
    • Updated client initialization and testing setups.
  • Chores
    • Updated dependency versions and configuration settings for enhanced compatibility.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@SammyOina SammyOina changed the title Cocos 364 COCOS-364 - Make agent more resilient to gRPC disconnection on cvms cloud server Feb 13, 2025
@codecov

codecov Bot commented Feb 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 43.63636% with 62 lines in your changes missing coverage. Please review.

Project coverage is 59.11%. Comparing base (bb0ad29) to head (b11c880).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
agent/cvms/api/grpc/client.go 47.47% 43 Missing and 9 partials ⚠️
agent/cvms/server/cvm.go 0.00% 8 Missing ⚠️
agent/service.go 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   59.57%   59.11%   -0.46%     
==========================================
  Files          54       55       +1     
  Lines        4574     4667      +93     
==========================================
+ Hits         2725     2759      +34     
- Misses       1564     1615      +51     
- Partials      285      293       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

drasko
drasko requested changes Feb 13, 2025
View reviewed changes
Comment thread agent/cvms/api/grpc/client.go Outdated
Comment thread cmd/agent/main.go Outdated
Comment thread cmd/agent/main.go Outdated
Comment thread cmd/agent/main.go Outdated
dborovcanin
dborovcanin requested changes Feb 14, 2025
View reviewed changes
Comment thread agent/cvms/api/grpc/client.go Outdated
@SammyOina
Refactor AgentServer interface and update related implementations; ad…
b5ed5c4 
…just dependency versions in go.mod

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
Implement State method for agent.Service and enhance metrics and logg…
138233c 
…ing middleware to track state changes

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
Update file permission modes to use octal notation in CVMS client and…
0ce6e03 
… agent main

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
Refactor CVMS client and agent main to improve function signatures an…
67bb82e 
…d variable naming for clarity

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
Remove unnecessary fmt import and logging statement in CVMSClient Pro…
5a57419 
…cess method

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
Add file-based storage implementation for message persistence in CVMS…
15e901e 
…Client

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
Update README and main.go for CVMS service: correct references and im…
8a758b8 
…prove clarity

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
Update README to clarify gRPC host and port descriptions for CVMS server
6f4bf3b 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
Rename sendMessageWithRetry to sendStreamMessage for clarity and cons…
ead0e0b 
…istency in CVMSClient

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
Update README to add detailed descriptions for algorithm and dataset …
6fb8292 
…paths

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@drasko drasko merged commit cef9cbb into ultravioletrs:main Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smithjilks smithjilks smithjilks approved these changes
@drasko drasko Awaiting requested review from drasko
@dborovcanin dborovcanin Awaiting requested review from dborovcanin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Report agent state to cloud Bug: Agent connection to cvms server does not persist

4 participants

@SammyOina @drasko @dborovcanin @smithjilks