COCOS-363 - Add verification of vTPM attestation to CLI#363
Merged
Conversation
SammyOina
requested changes
Jan 31, 2025
SammyOina
requested changes
Feb 5, 2025
0b69276 to
80a2edf
Compare
danko-miladinovic
requested changes
Feb 5, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
==========================================
- Coverage 61.06% 59.51% -1.56%
==========================================
Files 54 54
Lines 4371 4574 +203
==========================================
+ Hits 2669 2722 +53
- Misses 1422 1567 +145
- Partials 280 285 +5 ☔ View full report in Codecov by Sentry. |
SammyOina
requested changes
Feb 7, 2025
SammyOina
left a comment
Contributor
There was a problem hiding this comment.
help menu is shown when validation fails, also error message appears twice
SammyOina
requested changes
Feb 10, 2025
CLI attestation changes Add all modes to CLI changes updates Remove old attestation validateion command Make updates based on PR reviews Disable depreciated linter Linter fixes Resolve conflicts resolve go.mod errors Use previous version of go-sev-guest Modify tests Remove tdx attestation Fix error messages printing Add tests Fix CI failures Do proper error handling
3125807 to
dd2bed3
Compare
SammyOina
approved these changes
Feb 11, 2025
SammyOina
requested changes
Feb 11, 2025
SammyOina
approved these changes
Feb 11, 2025
dborovcanin
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
CLI attestation changes
Which issue(s) does this PR fix/relate to?
Issue #352
Have you included tests for your changes?
No, draft PR.
Did you document any new/modified feature?
Yes
Notes