NOISSUE - Set env automatically#355
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 62.28% 61.13% -1.16%
==========================================
Files 54 54
Lines 4261 4371 +110
==========================================
+ Hits 2654 2672 +18
- Misses 1344 1419 +75
- Partials 263 280 +17 ☔ View full report in Codecov by Sentry. |
WashingtonKK
requested changes
Jan 15, 2025
WashingtonKK
left a comment
Contributor
There was a problem hiding this comment.
Please add instructions for running with this architecture.
22f7730 to
fed92b7
Compare
Contributor
|
@SammyOina please fix rebase, you have agent/cvm [introduced in this PR, cocos-344-c] and agent/cvms [was merged to main from cocos-344-a]. |
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
74144b5 to
133ba2f
Compare
WashingtonKK
approved these changes
Jan 20, 2025
dborovcanin
requested changes
Jan 20, 2025
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
dborovcanin
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
New Features
Configuration Changes
Bug Fixes
Refactor
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes
manager creates vms and is a grpc server. CLI can be used as a client for manager to create and remove vms
when a vm is launched, agent will start inside the vm, agent constains the cvms grpc client which connects to the cloud cvms service/ test/cvms. once cvms client on agent connects to cloud, it is ready to receive run requests and start agent sever. once agent server starts algo and data sets can be sent and results can then be received.