COCOS-325 - Fix aTLS bug#332
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 65.49% 66.26% +0.77%
==========================================
Files 53 53
Lines 4327 4361 +34
==========================================
+ Hits 2834 2890 +56
+ Misses 1218 1201 -17
+ Partials 275 270 -5 ☔ View full report in Codecov by Sentry. |
SammyOina
approved these changes
Dec 11, 2024
dborovcanin
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix because it fixes the following issue: #325
What does this do?
This PR changes how the SSL shutdown is handeled. It fixes the situation where not all the data is read by the CLI or by the Agent but the connection is closed.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
This code is already covered by tests.
Did you document any new/modified feature?
This fix does not have to be documented.
Notes