Skip to content

Tweaked worker thread profiling text#997

Merged
vabrador merged 1 commit intodevelopfrom
update-dll-profiling-text
Apr 9, 2018
Merged

Tweaked worker thread profiling text#997
vabrador merged 1 commit intodevelopfrom
update-dll-profiling-text

Conversation

@Amarcolina
Copy link
Copy Markdown
Contributor

@Amarcolina Amarcolina commented Apr 9, 2018

No more dll, so switch the text to call out the profiling of the worker thread instead. Even though all the logic has been moved into Unity, we can't easily simplify the worker thread profiling logic because of the simple fact that we need to construct CustomSampler objects on the main thread, so all the existing back and forth still needs to be performed.

To test:

  • Make sure ServiceProvider and XRServiceProvider both look correct in the inspector and have good tooltips.

@Amarcolina Amarcolina added the DevX label Apr 9, 2018
@Amarcolina Amarcolina self-assigned this Apr 9, 2018
@Amarcolina Amarcolina requested a review from vabrador April 9, 2018 22:57
@vabrador vabrador merged commit 9ecd1b5 into develop Apr 9, 2018
@Amarcolina Amarcolina deleted the update-dll-profiling-text branch April 19, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants