Switch the Reconnection Counter to use frame number#1036
Merged
vabrador merged 4 commits intorelease-4.4.0from May 15, 2018
Merged
Switch the Reconnection Counter to use frame number#1036vabrador merged 4 commits intorelease-4.4.0from
vabrador merged 4 commits intorelease-4.4.0from
Conversation
Fixes a critical issue where the reconnection attempt could occur before the controller had been initially constructed; causing a freeze heavier applications (that took more than `RECONNECTION_INTERVAL` seconds to load).
Amarcolina
approved these changes
May 15, 2018
vabrador
approved these changes
May 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a critical issue where the reconnection attempt could occur before the controller had been initially constructed; causing a freeze heavier applications (that took more than
RECONNECTION_INTERVALseconds to load).