Skip to content

Fixes and some improvements to QuickButton#1033

Merged
vabrador merged 1 commit intorelease-4.4.0from
fix-ambiguous-quick-button
May 14, 2018
Merged

Fixes and some improvements to QuickButton#1033
vabrador merged 1 commit intorelease-4.4.0from
fix-ambiguous-quick-button

Conversation

@Amarcolina
Copy link
Copy Markdown
Contributor

@Amarcolina Amarcolina commented May 14, 2018

  • Allow QuickButton to invoke methods with arguments, as long as all arguments have default values
  • When there are multiple methods with the same name, but only one method is valid, it will always choose the single valid method.
  • When there is an error finding a valid method to invoke, the button will remain in the inspector instead of disappearing. It will instead be disabled and turn red, with the tooltip becoming the reason for the error (error is also still output to the console)
  • Button has been moved to the right side of the field instead of the left side. This is a quirk of the CombinablePropertyDrawer, it allows float fields to retain the ability to drag on the labels to change the float value.

To test:

  • Ensure that quick button still behaves as intended
  • Ensure that quick button can find the single valid method among multiple invalid methods with the same name
  • Ensure that quick button gives a good error message in cases where it cannot find a valid method

@Amarcolina Amarcolina self-assigned this May 14, 2018
@Amarcolina Amarcolina requested a review from vabrador May 14, 2018 19:54
@vabrador vabrador merged commit e6d8db7 into release-4.4.0 May 14, 2018
@vabrador vabrador deleted the fix-ambiguous-quick-button branch May 14, 2018 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants