Add attempts to reconnect to the service when not connected#1032
Merged
Amarcolina merged 2 commits intorelease-4.4.0from May 14, 2018
Merged
Add attempts to reconnect to the service when not connected#1032Amarcolina merged 2 commits intorelease-4.4.0from
Amarcolina merged 2 commits intorelease-4.4.0from
Conversation
This PR attempts to solve the sporadic issue that sometimes occurs where users will client applications will spuriously not receive hands; we suspect it's caused by the service not acknowledging the connection attempt by the app the first time, so we attempt to simulate an "app restart" by destroying and recreating the controller object. You can easily test whether doing this could break working apps by adding ` && !Input.GetKey(KeyCode.Space)` to the service connection check on line 506 and holding down Space for several seconds (to artificially induce a "Destroy/Create" cycle). Co-Authored-By: Nicholas Benson <nickjbenson@users.noreply.github.com>
Contributor
|
do we want to reset |
Amarcolina
approved these changes
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve the sporadic issue that sometimes occurs where users will client applications will spuriously not receive hands; we suspect it's caused by the service not acknowledging the connection attempt by the app the first time, so we attempt to simulate an "app restart" by destroying and recreating the controller object.
You can easily test whether doing this could break working apps by adding
&& !Input.GetKey(KeyCode.Space)to the service connection check on line 506 and holding down Space for several seconds (to artificially induce a "Destroy/Create" cycle).