Disable global interpreter lock for freethreading#737
Merged
Conversation
Collaborator
Author
|
CC @ngoldbaum (GitHub won't let me add you as a reviewer) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
- Coverage 92.58% 92.52% -0.07%
==========================================
Files 7 7
Lines 2199 2206 +7
==========================================
+ Hits 2036 2041 +5
- Misses 163 165 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think it's worth adding. Here's the check I added in NumPy for the same thing, to also catch any test dependencies enabling the GIL: |
ngoldbaum
approved these changes
May 25, 2026
ngoldbaum
left a comment
There was a problem hiding this comment.
Thanks so much! Tested locally and I no longer see the GIL getting enabled.
Collaborator
Author
|
Great, thanks for the confirmation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #708 (comment). Closes #684.
The test is probably pointless but it makes me feel better... 🙂