Replace generated version.h with macro#735
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
=======================================
Coverage 92.58% 92.58%
=======================================
Files 7 7
Lines 2199 2199
=======================================
Hits 2036 2036
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bwoodsend
approved these changes
May 15, 2026
Collaborator
|
That's much nicer than having that generated header file floating around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #734.
Looking inside the wheels for 5.12.0 and 5.12.1:
The new one contains
./src/ujson/python/version.hwhich isn't meant to be in the wheel.This caused by a change in the new setuptools_scm 10.0.0 relating to
src/layouts.The easiest fix is to drop the generated file, and replace it with a macro, as the version is only used in one place.