Inline stubs#674
Conversation
ee619cc to
4e4ca0a
Compare
175a5fe to
fbb2bd6
Compare
|
|
| - name: Stubtest | ||
| if: "!startsWith(matrix.python-version, 'pypy')" | ||
| run: | | ||
| # Check that stubs have no omitted / extraneous symbols. | ||
| # This does not check the signatures: https://github.com/python/mypy/issues/19261. | ||
| python -m mypy.stubtest ujson |
There was a problem hiding this comment.
Do we need to run this on all operating systems with (nearly) all Python versions, or is just one okay? If just one, we can move it to lint.yml.
It only takes a couple of seconds to run, so that's not a problem.
There was a problem hiding this comment.
sure, done, thanks!
There was a problem hiding this comment.
If you expose the same symbol names for all environments, then a single run should cover everything.
Since c module extensions signatures can't be checked, you don't even need to bother with function signatures that would differ on, let's say Windows vs macOS.
There was a problem hiding this comment.
sure, thanks @Avasam - I've done that in lint.yml, so there should just be a single run
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Fixes #671
Changes proposed in this pull request:
packages = ujson-stubsinsetup.cfg