Fix undefined behavior in Buffer_AppendLongUnchecked#606
Conversation
|
Looks like |
|
Ah interesting - I'll have to look further into that. I fixed this downstream in pandas and didn't have the MSVC issue; must be something different with the compilation options |
|
Ignore previous comment around test - for sure I'll add that |
|
Bah sorry it is in the test suite already: Line 202 in 6c2514e |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 91.66% 91.67%
=======================================
Files 6 6
Lines 1944 1946 +2
=======================================
+ Hits 1782 1784 +2
Misses 162 162
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bwoodsend
left a comment
There was a problem hiding this comment.
Rather disconcerting that we have a test specifically for this which didn't notice this issue...
|
Thanks! |
This was flagged when running with UBSAN