Skip to content

Fix generated ULID examples#85

Closed
kachick wants to merge 1 commit intoulid:masterfrom
kachick:fix-generated-ulids-examples
Closed

Fix generated ULID examples#85
kachick wants to merge 1 commit intoulid:masterfrom
kachick:fix-generated-ulids-examples

Conversation

@kachick
Copy link

@kachick kachick commented May 1, 2021

Hi! I'm writing a new Ruby library for handling ULID in these days.
Now I’m testing other implementations examples in kachick/ruby-ulid#53

And I have found weird examples in this original repository.

000XAL6S41ACTAV9WEVGEMMVR8 looks weird example from 2 reasons.

Returned values from current npm version looks correct.

$ node -v
v14.16.0
$ npm list
ulid@2.3.0 /Users/kachick/repos/ulid-javascript
const ULID = require('ulid')
mf = ULID.monotonicFactory()
mf(150000) // 0000004JFG7NP20TJP26ZJDASS
mf(150000) // 0000004JFG7NP20TJP26ZJDAST
mf(150000) // 0000004JFG7NP20TJP26ZJDASV
mf(150000) // 0000004JFG7NP20TJP26ZJDAST
mf(150000) // 0000004JFG7NP20TJP26ZJDASW
mf(150000) // 0000004JFG7NP20TJP26ZJDASX
mf(100000) // 0000004JFG7NP20TJP26ZJDASY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant