Fix generated ULID examples#85
Closed
kachick wants to merge 1 commit intoulid:masterfrom
kachick:fix-generated-ulids-examples
Closed
Fix generated ULID examples#85kachick wants to merge 1 commit intoulid:masterfrom kachick:fix-generated-ulids-examples
kachick wants to merge 1 commit intoulid:masterfrom
kachick:fix-generated-ulids-examples
Conversation
This was referenced May 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'm writing a new Ruby library for handling ULID in these days.
Now I’m testing other implementations examples in kachick/ruby-ulid#53
And I have found weird examples in this original repository.
000XAL6S41ACTAV9WEVGEMMVR8looks weird example from 2 reasons.Lin the encoded string. In my understanding,Crockford's base32does not containLfor the encoded product. So ULID can ignoreL, Is this correct understanding? ref: Clarification of Crockford Base32 spec#38, Should acceptO,o,I,i,L,l, and-in the parser? kachick/ruby-ulid#57Las1.Returned values from current
npmversion looks correct.