Conversation
|
This is great. Can you please resolve the merge conflict? Sorry I recently bumped a bunch of deps. |
|
@kaikalii I've used the Cargo.lock from main and then ran |
|
Yes |
e9dd0f6 to
9e00c24
Compare
|
I've resolved the conflicts, but it doesn't seem to generate the same results on native vs pad. |
|
I've updated the hashing of shape to use u64 rather than usize (which varies in hash implementation by platform, I wasn't aware when looking through the write_usize code). I will note all the standard hashing will only work on the same endianness (granted almost all platforms are little endian, including wasm and amd64, so that should be fine) Some other notes here: https://github.com/hoxxep/portable-hash?tab=readme-ov-file#whats-wrong-with-the-stdhash-traits |
|
I tested it out and it does actually work on the web target now |
|
I think hashmaps using this is unnecessary for now. |

(Hi @amatgil! Thanks for the original PR)
This uses unreleased features in the
randcrate to make gen deterministic and portable. Currently a draft as these features are only in a release candidate of rand. From reading the documentation, HighwayHash and Xoshiro256PlusPlus should both be reproducible and deterministic but I haven't tested myself, more testing is welcome.Test vector:
⍤⤙≍ gen [] 1 0.2791433297717809