Conversation
|
I don't want to break compatibility with python 2.6 (and potentially earlier) for this. Do you have a compelling argument in favour of ordering dictionaries? |
|
@uiri You still can use the ordereddict package from PyPI |
|
preserving orders is an extra feature and it's useful when we want to doing jobs in orders that exist in toml file so its nice to preserving orders by default |
I'm not sure how to handle the dependency of the ordereddict package which @untitaker mentioned. |
|
You just can check for the version inside the setup.py and supply the setup function with the dependency if neccessary. This is how i have handled it in untitaker/python-webuntis and it works quite well. |
|
Unfortunately the official spec from mojombo/toml doesn't indicate whether hashes have order or not. |
|
@untitaker i'm not familiar with setuptools , can you fix it ? |
|
@untitaker i inform mojombo about this issue |
|
@beygi Is it okay if i make a pull request to your fork, so it shows up in this one? |
|
@untitaker its okay , when your work is done i send a new pull request . thank you :) |
|
If you merge beygi#1, the changes will show up here. |
Use ordereddict from PyPI for Python < 2.7
|
And it seems that this point has been made unneccessary by the response in toml-lang/toml#162 anyway. |
|
Given that mojombo has stated not to preserve order (or at least that it is not a requirement), I'm closing this pull request. |
|
@uiri this is an extra feature ! and its good to keep it :) |
No description provided.