Skip to content

Add WP_STATELESS_SKIP_ACL_SET for skip ACL set for GCS#625

Merged
planv merged 2 commits intoudx:latestfrom
vsychov:acl-skip
Oct 16, 2023
Merged

Add WP_STATELESS_SKIP_ACL_SET for skip ACL set for GCS#625
planv merged 2 commits intoudx:latestfrom
vsychov:acl-skip

Conversation

@vsychov
Copy link
Copy Markdown
Contributor

@vsychov vsychov commented Nov 25, 2021

Hi there,

currently this plugin fails when GCS bucket created with uniform bucket-level access, that not support ACL. So plugin cannot insert legacy ACL for an object when uniform bucket-level access is enabled.

This PR add WP_STATELESS_SKIP_ACL_SET constant, that fix it.

Solve #521

Copy link
Copy Markdown

@lukefly lukefly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job. thanks!

@planv
Copy link
Copy Markdown
Contributor

planv commented Jun 21, 2023

Hello @vsychov

Thank you for your involving.

We are going to release this feature with new version of WP-Stateless.

@planv planv added this to the v3.2.5 milestone Jun 21, 2023
@ewsopp ewsopp requested review from balexey88 and planv and removed request for planv September 29, 2023 17:11
Fix logic of processing new WP_STATELESS_SKIP_ACL_SET constant
@planv planv changed the base branch from v3.0 to latest October 16, 2023 10:35
@planv planv merged commit 0e6ae5c into udx:latest Oct 16, 2023
@planv planv mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants