Skip to content

Support for lambdas :)#2465

Merged
nikivazou merged 10 commits into
ucsd-progsys:developfrom
AlecsFerra:develop
Dec 16, 2024
Merged

Support for lambdas :)#2465
nikivazou merged 10 commits into
ucsd-progsys:developfrom
AlecsFerra:develop

Conversation

@AlecsFerra

@AlecsFerra AlecsFerra commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

Its breaking two tests related to typeclasses, both caused by the same file that breaks elaboration.

Companion PR in LF: ucsd-progsys/liquid-fixpoint#725

@AlecsFerra

Copy link
Copy Markdown
Contributor Author

Some examples

@nikivazou

Copy link
Copy Markdown
Member

That is amazing!!!! Though some tests seems to fail :'(

@AlecsFerra

Copy link
Copy Markdown
Contributor Author

That is amazing!!!! Though some tests seems to fail :'(

Yeah is just the usual suspect tests/classes/pos/STMonad.hs everything else should work

@AlecsFerra

Copy link
Copy Markdown
Contributor Author

Added some tests and fixed the issue with tests/classes/pos/STMonad.hs thanks to @nikivazou

Comment thread .gitmodules Outdated

@facundominguez facundominguez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlecsFerra! I make one request for documentation below.

If there are some limitations to keep in mind, it may be worth mentioning them in the user documentation.

Comment thread liquidhaskell-boot/src/Language/Haskell/Liquid/Bare/Axiom.hs
@AlecsFerra

Copy link
Copy Markdown
Contributor Author

If there are some limitations to keep in mind, it may be worth mentioning them in the user documentation.

AFAIK there are no limitations

@facundominguez facundominguez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments!

Comment thread liquidhaskell-boot/src/Language/Haskell/Liquid/Bare/Axiom.hs Outdated
Comment thread liquidhaskell-boot/src/Language/Haskell/Liquid/Bare/Axiom.hs Outdated
Comment thread liquidhaskell-boot/src/Language/Haskell/Liquid/Bare/Axiom.hs
Comment thread liquidhaskell-boot/src/Language/Haskell/Liquid/Bare/Axiom.hs
Comment thread liquidhaskell-boot/src/Language/Haskell/Liquid/Bare/Axiom.hs

@facundominguez facundominguez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nikivazou nikivazou merged commit 791567f into ucsd-progsys:develop Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants