Avoid re-typechecking 🚀╰(*°▽°*)╯#2389
Merged
facundominguez merged 15 commits intoOct 17, 2024
Merged
Conversation
everything is done as late as possible, i.e. explicitly showing which steps require re-typechecking and which steps require re-desugaring.
1053cf0 to
6c840ab
Compare
hsyl20
reviewed
Oct 16, 2024
6c840ab to
55455d4
Compare
facundominguez
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @gergoerdi! Quite an achievement. I've sprinkled some questions in parts that I don't fully understand.
55455d4 to
8d45cc7
Compare
Contributor
Author
Yeah I'm quite proud of getting this to work. |
8d45cc7 to
9b43230
Compare
012b5b0 to
1d3d681
Compare
Contributor
Author
|
Net -30 lines of code, that's how you know it's the good stuff! |
just postprocess the result of normal typechecking before passing it to the desugarer. See https://gitlab.haskell.org/ghc/ghc/-/issues/24386 for some background on why we even need to do this.
module, so we just need to `unoptimise` it.
1d3d681 to
2c59a0a
Compare
2c59a0a to
d67aef7
Compare
| = def &= help "Dump pre-normalized core (before a-normalization)" | ||
| &= name "dump-pre-normalized-core" | ||
| &= explicit | ||
| , insertCoreBreakPoints |
Collaborator
There was a problem hiding this comment.
The flag is still mentioned in the changelog for the next release.
Collaborator
|
I contributed a commit to remove the boolean from the recursion in |
Contributor
Author
|
Don't know how to add comment to specific line on mobile... I think it's nicer if you use a record pattern match to take the |
a22e6fb to
e23da17
Compare
facundominguez
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finally solves the long-standing problem of the LH plugin running the GHC typechecker. Note that this works without requiring anything new from GHC.
I guarantee you this will be the best PR you get from me this week :P