Fully qualify names in CoreToLogic#2327
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #2319, in this PR we fully qualify symbols when transforming CoreExpr into Expr of the logic so we don't mistake builtin symbols with functions defined by the user (see example in the issue).
Worth mentioning, it means that this does not pass verification:
If you want to refer to your reflected functions that clash with builtin symbols of the logic, you have to fully qualify them:
So that there's no ambiguity. Without qualification, we assume
not(or the like) to refer to the builtin symbols from the logic.Any comments welcome!