Implementation of assume-reflect#2313
Merged
Merged
Conversation
Member
|
Wow this is awesome, thanks!!! |
Contributor
Author
|
I see that there are compile errors for the |
Collaborator
|
I think the error is due to the fact that liquidhaskell is build with |
Comment on lines
+712
to
+717
| -- We make sure that the reflected functions are excluded from `gsAsmSigs`, except for the signatures of | ||
| -- actual functions in assume-reflect. The latter are added here because 1. it's what makes tests work | ||
| -- and 2. so that we probably "shadow" the old signatures of the actual function correctly. Note that even if the | ||
| -- signature of the actual function was asserted and not assumed, we do not put our new signature for the actual function | ||
| -- in `gsTySigs` (which is for asserted signatures). Indeed, the new signature will *always* be an assumption since we | ||
| -- add the extra post-condition that the actual and pretended function behave in the same way. |
Collaborator
There was a problem hiding this comment.
Even though this is merged, I still would like to know what you think and would contribute edits if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the implementation of assume-reflect, following the specification given in #2310. Any comments welcome!