Skip to content

elaboration#753

Merged
nikivazou merged 7 commits into
developfrom
T2324
Jun 2, 2025
Merged

elaboration#753
nikivazou merged 7 commits into
developfrom
T2324

Conversation

@nikivazou

@nikivazou nikivazou commented May 21, 2025

Copy link
Copy Markdown
Member

Refine elaboration as required for ucsd-progsys/liquidhaskell#2535

This edit required for the test https://github.com/ucsd-progsys/liquid-fixpoint/blob/2f3c896c8790738d2701ac109e14ee6525d7efc1/tests/pos/T753.fq

because it needs the sort of the function in a function call.

@nikivazou

Copy link
Copy Markdown
Member Author

Can we merge?

@facundominguez

Copy link
Copy Markdown
Collaborator

Thanks Niki! I don't oppose merging, but I think that without additional action it will be difficult for others to maintain the code.

It looks to me like the test 753.fq is too large. Imagine it starts failing in the future, how would you make sense of all the constraints in there? If it comes from Liquid Haskell, I'd let it stay in Liquid Haskell.

Also, two artifacts would make maintaining this code easier:

  1. A small test that rehearses the changes
  2. A comment explaining what the problem was with the old implementation and how the changes addresses it. The code could have it, or it could have a reference to the PR or issue where it is explained. Otherwise, I'd expect the insights to get lost in the flux of time.

@nikivazou

Copy link
Copy Markdown
Member Author

ok! I will try to minimize the test!

@nikivazou

Copy link
Copy Markdown
Member Author

Shall we merge?

@facundominguez

Copy link
Copy Markdown
Collaborator

Thanks Niki! I removed the large tests/pos/T753.fq now that there is the smaller tests/pos/T753a.fq. But please, let me know if this is not what you want. I think we could merge when CI passes.

@nikivazou nikivazou merged commit e41a196 into develop Jun 2, 2025
9 checks passed
@ranjitjhala ranjitjhala deleted the T2324 branch October 15, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants